Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-statements: Fix toc error #3208

Merged
merged 3 commits into from Jul 10, 2020
Merged

sql-statements: Fix toc error #3208

merged 3 commits into from Jul 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2020

What is changed, added or deleted? (Required)

This bug was introduced by #3198

I only noticed it when trying to fix the cherry picks into 3.0 and 3.1, which are not affected.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ghost ghost added the needs-cherry-pick-4.0 label Jul 9, 2020
@yikeke yikeke requested review from yikeke and bb7133 July 10, 2020 06:38
@yikeke yikeke added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 10, 2020
yikeke
yikeke approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

@yikeke,Thanks for your review.

@yikeke
Copy link
Contributor

yikeke commented Jul 10, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4145e5b into pingcap:master Jul 10, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 10, 2020
@ti-srebot
cherry pick pingcap#3208 to release-4.0
1bf105c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 10, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3228

yikeke pushed a commit that referenced this pull request Jul 10, 2020
@ti-srebot
cherry pick #3208 to release-4.0 (#3228)
2950cbf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Null not nil <67764674+nullnotnil@users.noreply.github.com>
@yikeke yikeke added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 20, 2020
@yikeke yikeke assigned Joyinqin and unassigned ireneontheway Jul 28, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 11, 2020
Closed
9 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 11, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Aug 11, 2020
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Aug 20, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 21, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 21, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Aug 21, 2020
@Joyinqin Joyinqin mentioned this pull request Aug 28, 2020
Merged
9 tasks
This was referenced Sep 1, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @yikeke @Joyinqin @TomShawn @ireneontheway